From 2a34986acb7fc1a717794d43f758665cc80b7542 Mon Sep 17 00:00:00 2001 From: Arksine Date: Wed, 2 Sep 2020 17:13:25 -0400 Subject: [PATCH] file_manager: check for unsuccessful attempt at metadata extraction If the metadata script encoutners an error it will return an empty dict for the "metadata" item. Do not update the metadata storage or send a notification if the dict is empty. Signed-off-by: Eric Callahan --- moonraker/plugins/file_manager.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/moonraker/plugins/file_manager.py b/moonraker/plugins/file_manager.py index 8b5cad4..3a3ca71 100644 --- a/moonraker/plugins/file_manager.py +++ b/moonraker/plugins/file_manager.py @@ -535,6 +535,9 @@ class MetadataStorage: raise self.server.error("Unable to extract metadata") path = self.script_response['file'] metadata = self.script_response['metadata'] + if not metadata: + # This indicates an error, do not add metadata for this + raise self.server.error("Unable to extract metadata") self.metadata[path] = dict(metadata) metadata['filename'] = path if do_notify: