3diy
/
klipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sched: Interrupts must be disabled during setjmp() call 

On the AVR platform (and possibly others) the longjmp() call will
restore the interrupt state saved during the setjmp() call.  So, the
setjmp() call must be invoked with interrupts disabled to ensure that
shutdown handling is run with interrupts disabled.  This fixes
potential corruption of the shutdown processing on AVR.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
This commit is contained in:
Kevin O'Connor 2017-12-21 12:41:27 -05:00
parent 1d21bf66c6
commit d303e556ad
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/sched.c
View File

@ -282,6 +282,7 @@ sched_clear_shutdown(void)
static void
run_shutdown(int reason)
{
irq_disable();
uint32_t cur = timer_read_time();
if (!shutdown_status)
shutdown_reason = reason;
@ -334,9 +335,11 @@ sched_main(void)
sendf("starting");
irq_disable();
int ret = setjmp(shutdown_jmp);
if (ret)
run_shutdown(ret);
irq_enable();
run_tasks();
}