command: Add a command_encode_and_frame() helper

Add a helper function that calls command_encodef() followed by
command_add_frame().

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>

src/avr/usbserial.c

@@ -65,8 +65,7 @@ console_sendf(const struct command_encoder *ce, va_list args)
 {
     // Generate message
     static uint8_t buf[MESSAGE_MAX];
-    uint8_t msglen = command_encodef(buf, ce, args);
+    uint8_t msglen = command_encode_and_frame(buf, ce, args);
-    command_add_frame(buf, msglen);
 
     // Transmit message
     usb_serial_write((void*)buf, msglen);

src/command.c

@@ -167,6 +167,16 @@ command_add_frame(uint8_t *buf, uint_fast8_t msglen)
     buf[msglen - MESSAGE_TRAILER_SYNC] = MESSAGE_SYNC;
 }
 
+// Encode a message and then add a message block frame around it
+uint_fast8_t
+command_encode_and_frame(uint8_t *buf, const struct command_encoder *ce
+                         , va_list args)
+{
+    uint_fast8_t msglen = command_encodef(buf, ce, args);
+    command_add_frame(buf, msglen);
+    return msglen;
+}
+
 static uint8_t in_sendf;
 
 // Encode and transmit a "response" message

src/command.h

@@ -65,8 +65,10 @@ uint8_t *command_parsef(uint8_t *p, uint8_t *maxend
                         , const struct command_parser *cp, uint32_t *args);
 uint_fast8_t command_encodef(uint8_t *buf, const struct command_encoder *ce
                              , va_list args);
-void command_sendf(const struct command_encoder *ce, ...);
 void command_add_frame(uint8_t *buf, uint_fast8_t msglen);
+uint_fast8_t command_encode_and_frame(
+    uint8_t *buf, const struct command_encoder *ce, va_list args);
+void command_sendf(const struct command_encoder *ce, ...);
 int_fast8_t command_find_block(uint8_t *buf, uint_fast8_t buf_len
                                , uint_fast8_t *pop_count);
 void command_dispatch(uint8_t *buf, uint_fast8_t msglen);

src/generic/serial_irq.c

@@ -108,8 +108,7 @@ console_sendf(const struct command_encoder *ce, va_list args)
 
     // Generate message
     uint8_t *buf = &transmit_buf[tmax];
-    uint_fast8_t msglen = command_encodef(buf, ce, args);
+    uint_fast8_t msglen = command_encode_and_frame(buf, ce, args);
-    command_add_frame(buf, msglen);
 
     // Start message transmit
     writeb(&transmit_max, tmax + msglen);

src/generic/usb_cdc.c

@@ -65,8 +65,7 @@ console_sendf(const struct command_encoder *ce, va_list args)
 
     // Generate message
     uint8_t *buf = &transmit_buf[tpos];
-    uint_fast8_t msglen = command_encodef(buf, ce, args);
+    uint_fast8_t msglen = command_encode_and_frame(buf, ce, args);
-    command_add_frame(buf, msglen);
 
     // Start message transmit
     transmit_pos = tpos + msglen;

src/linux/console.c

@@ -176,8 +176,7 @@ console_sendf(const struct command_encoder *ce, va_list args)
 {
     // Generate message
     uint8_t buf[MESSAGE_MAX];
-    uint_fast8_t msglen = command_encodef(buf, ce, args);
+    uint_fast8_t msglen = command_encode_and_frame(buf, ce, args);
-    command_add_frame(buf, msglen);
 
     // Transmit message
     int ret = write(main_pfd[MP_TTY_IDX].fd, buf, msglen);