3diy
/
klipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pru: Remove unnecessary barrier() calls 

The writel() call already implements a barrier() internally.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
This commit is contained in:
Kevin O'Connor 2017-06-16 14:18:30 -04:00
parent ba58e0446d
commit bd48c3a083
2 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/pru/main.c
View File

@ -114,7 +114,6 @@ console_get_input(uint8_t *plen)
void
console_pop_input(uint8_t len)
{
barrier();
writel(&SHARED_MEM->read_count, 0);
}
@ -136,7 +135,6 @@ void
console_push_output(uint8_t len)
{
uint32_t send_push_pos = SHARED_MEM->send_push_pos;
barrier();
writel(&SHARED_MEM->send_data[send_push_pos].count, len);
write_r31(R31_WRITE_IRQ_SELECT | (KICK_PRU0_EVENT - R31_WRITE_IRQ_OFFSET));
SHARED_MEM->send_push_pos = (

3
src/pru/pru0.c
View File

@ -40,7 +40,6 @@ check_can_send(struct pru_rpmsg_transport *transport)
pru_rpmsg_send(
transport, CHAN_PORT, transport_dst
, &SHARED_MEM->send_data[send_pop_pos].data, count);
barrier();
writel(&SHARED_MEM->send_data[send_pop_pos].count, 0);
SHARED_MEM->send_pop_pos = (
(send_pop_pos + 1) % ARRAY_SIZE(SHARED_MEM->send_data));
@ -59,7 +58,6 @@ check_can_read(struct pru_rpmsg_transport *transport)
if (ret || !len)
return;
SHARED_MEM->read_pos = 0;
barrier();
writel(&SHARED_MEM->read_count, len);
write_r31(R31_WRITE_IRQ_SELECT | (KICK_PRU1_EVENT - R31_WRITE_IRQ_OFFSET));
}
@ -107,7 +105,6 @@ adc_reset(void)
ADC->step[i].delay = 0;
}
// Enable ADC
barrier();
writel(&ADC->ctrl, 0x07);
// Drain fifo
while (readl(&ADC->fifo0count))