From 647a1cd8caacdae5e9f2c791688fe649d376b99b Mon Sep 17 00:00:00 2001 From: Kevin O'Connor Date: Thu, 7 Apr 2022 12:10:48 -0400 Subject: [PATCH] temperature_fan: Remove deprecated pid_integral_max option Signed-off-by: Kevin O'Connor --- docs/Config_Changes.md | 3 +++ klippy/extras/temperature_fan.py | 4 +--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/Config_Changes.md b/docs/Config_Changes.md index 4e708022..ca97a6cc 100644 --- a/docs/Config_Changes.md +++ b/docs/Config_Changes.md @@ -8,6 +8,9 @@ All dates in this document are approximate. ## Changes +20220407: The temperature_fan `pid_integral_max` config option has +been removed (it was deprecated on 20210612). + 20220407: The default color order for pca9632 LEDs is now "RGBW". Add an explicit `color_order: RBGW` setting to the pca9632 config section to obtain the previous behavior. diff --git a/klippy/extras/temperature_fan.py b/klippy/extras/temperature_fan.py index 80ae162a..92dda7e0 100644 --- a/klippy/extras/temperature_fan.py +++ b/klippy/extras/temperature_fan.py @@ -147,9 +147,7 @@ class ControlPID: self.Ki = config.getfloat('pid_Ki') / PID_PARAM_BASE self.Kd = config.getfloat('pid_Kd') / PID_PARAM_BASE self.min_deriv_time = config.getfloat('pid_deriv_time', 2., above=0.) - imax = config.getfloat('pid_integral_max', - self.temperature_fan.get_max_speed(), minval=0.) - self.temp_integ_max = imax / self.Ki + self.temp_integ_max = self.temperature_fan.get_max_speed() / self.Ki self.prev_temp = AMBIENT_TEMP self.prev_temp_time = 0. self.prev_temp_deriv = 0.