From 3ea2e4fc582465242aa1daa5669021465db0467f Mon Sep 17 00:00:00 2001 From: Kevin O'Connor Date: Wed, 10 Mar 2021 11:38:05 -0500 Subject: [PATCH] tmc2660: Do not enable SFILT by default None of the other TMC driver enable SFILT by default and it seems enabling SFILT may not be ideal for sensorless homing. Signed-off-by: Kevin O'Connor --- docs/Config_Changes.md | 3 +++ docs/Config_Reference.md | 2 +- klippy/extras/tmc2660.py | 3 +-- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/docs/Config_Changes.md b/docs/Config_Changes.md index 3aeedb0e..0236fbd6 100644 --- a/docs/Config_Changes.md +++ b/docs/Config_Changes.md @@ -6,6 +6,9 @@ All dates in this document are approximate. # Changes +20210310: The TMC2660 default for driver_SFILT has been changed from 1 +to 0. + 20210227: TMC stepper motor drivers in UART or SPI mode are now queried once per second whenever they are enabled - if the driver can not be contacted or if the driver reports an error, then Klipper will diff --git a/docs/Config_Reference.md b/docs/Config_Reference.md index 28d22945..8ebb511c 100644 --- a/docs/Config_Reference.md +++ b/docs/Config_Reference.md @@ -2817,7 +2817,7 @@ run_current: #driver_SEMAX: 0 #driver_SEUP: 0 #driver_SEMIN: 0 -#driver_SFILT: 1 +#driver_SFILT: 0 #driver_SGT: 0 #driver_SLPH: 0 #driver_SLPL: 0 diff --git a/klippy/extras/tmc2660.py b/klippy/extras/tmc2660.py index 8790ddbe..9d68adf3 100644 --- a/klippy/extras/tmc2660.py +++ b/klippy/extras/tmc2660.py @@ -100,7 +100,6 @@ FieldFormatters = dict(tmc2130.FieldFormatters) FieldFormatters.update({ "DEDGE": (lambda v: "1(Both Edges Active!)" if v else ""), "CHM": (lambda v: "1(constant toff)" if v else "0(spreadCycle)"), - "SFILT": (lambda v: "1(Filtered mode)" if v else "0(Standard mode)"), "VSENSE": (lambda v: "%d(%dmV)" % (v, 165 if v else 305)), "SDOFF": (lambda v: "1(Step/Dir disabled!)" if v else ""), "DISS2G": (lambda v: "%d(Short to GND disabled!)" if v else ""), @@ -256,7 +255,7 @@ class TMC2660: set_config_field(config, "SEMIN", 0) # SGSCONF - set_config_field(config, "SFILT", 1) + set_config_field(config, "SFILT", 0) set_config_field(config, "SGT", 0) # DRVCONF