From 6b0928bfc6b7f42f4699142d077ffb0f1f4cdca7 Mon Sep 17 00:00:00 2001 From: thelastWallE <12502210+thelastWallE@users.noreply.github.com> Date: Tue, 30 Mar 2021 21:25:25 +0200 Subject: [PATCH 1/2] -css for editor -fix for FillDataset checkbox, before any Graph was shown --- octoprint_klipper/static/css/klipper.css | 13 ++++++++---- octoprint_klipper/static/js/klipper_graph.js | 21 ++++++++++--------- .../templates/klipper_settings.jinja2 | 9 ++++---- 3 files changed, 24 insertions(+), 19 deletions(-) diff --git a/octoprint_klipper/static/css/klipper.css b/octoprint_klipper/static/css/klipper.css index ecf5e1f..8a5d87a 100644 --- a/octoprint_klipper/static/css/klipper.css +++ b/octoprint_klipper/static/css/klipper.css @@ -94,18 +94,23 @@ ul#klipper-settings { } #settings_plugin_klipper form .tab-content .tab-pane { - height: 100%; + height: calc(100% - 35px); } #settings_plugin_klipper form .tab-content .tap-pane#conf .control-group { margin-bottom: 0px; - height: 99%; + height: 100%; } -div#settings_plugin_klipper form div.tab-content #confdiv.tap-pane div.control-group button { +div#settings_plugin_klipper.tab-pane.active form.form-horizontal div.tab-content div#conf.tab-pane.active div.control-group div.conf-editor { + height: 100%; + overflow: auto; +} + +div#settings_plugin_klipper.tab-pane.active form.form-horizontal div.tab-content div#conf.tab-pane.active div.control-group button.btn.btn-small { width: 30%; display: inline-block; - margin: 2px; + margin: 0px 2px 2px 2px; } #macros #item.control-group { diff --git a/octoprint_klipper/static/js/klipper_graph.js b/octoprint_klipper/static/js/klipper_graph.js index bfff755..e79742c 100644 --- a/octoprint_klipper/static/js/klipper_graph.js +++ b/octoprint_klipper/static/js/klipper_graph.js @@ -35,6 +35,7 @@ function KlipperGraphViewModel(parameters) { self.canvas; self.canvasContext; self.chart; + self.chart.update; self.spinnerDialog; self.onStartup = function() { @@ -94,16 +95,6 @@ function KlipperGraphViewModel(parameters) { } } - self.toggleDatasetFill = function() { - if(self.datasets) { - for (i=0; i < self.datasets().length; i++) { - self.datasets()[i].fill = self.datasetFill(); - } - self.chart.update(); - } - return true - } - self.convertTime = function(val) { return moment(val, "X"); } @@ -220,6 +211,16 @@ function KlipperGraphViewModel(parameters) { } }); } + + self.toggleDatasetFill = function() { + if(self.datasets) { + for (i=0; i < self.datasets().length; i++) { + self.datasets()[i].fill = self.datasetFill(); + } + self.chart.update(); + } + return true + } } OCTOPRINT_VIEWMODELS.push({ diff --git a/octoprint_klipper/templates/klipper_settings.jinja2 b/octoprint_klipper/templates/klipper_settings.jinja2 index da17f54..83f5c36 100644 --- a/octoprint_klipper/templates/klipper_settings.jinja2 +++ b/octoprint_klipper/templates/klipper_settings.jinja2 @@ -203,11 +203,10 @@ - - -
+